Repository navigation
Tell a watcher when a workspace stops on a question, and what it asked - #86
Merged
Merged
Conversation
On a runner with a presentation feed every live event is handled inside the catch-up pass, so the ask notice for notify_when_done, guarded on that pass, never fired: the watching chat kept waiting on a workspace that was blocked on the owner. Only an ask from a turn since replaced is stale, so that is now the one condition, decided in the core.
The CLI sends no description with AskUserQuestion, so workspace_list showed an empty summary and the notify_when_done notice said only that a question was asked. Both now carry the question and its options from the ask's input, the notice inside the same fence as a last message.
stebrl
marked this pull request as ready for review
November 6, 2026 22:38
freekmurze
approved these changes
Nov 9, 2026
freekmurze
left a comment
freekmurze
left a comment
Member
There was a problem hiding this comment.
Reviewed correctness, concurrency and security. Fixed feed reconciliation and durable pending-question handling, added escaping and truncation regressions, and verified full CI on 1c45271.
Member
|
Thanks @stebrl for finding both watcher gaps and contributing the fix. Merged with additional feed-recovery, automatic-approval and security regression coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notify a watching chat when another workspace blocks on a question or permission prompt. Reconcile the presentation feed first and check stored unanswered questions so automatic approvals and old turns cannot spend the watch.
Include the question and options in the notice and workspace listing. Notices bound and fence the other agent's text, with regression coverage for feed recovery, resolved questions, truncation and marker escaping.
Download the pinned CI tools through the GitHub release API after repeated HTTP 504 responses from the plain asset URLs.